Genesis Sample 2.9.0 #206
Merged
Genesis Sample 2.9.0 #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update changelog and versions.
Resolve phpcs errors for VS Code phpcs extension.
This is no longer needed in Genesis 2.9+, as WordPress generates the slug automatically from the title.
TODO: test and adapt inline styles for use in Genesis Sample.
The block editor does not emit inline styles for the 'normal' size.
- Equivalent front-end CSS is now added in `inline-styles.php`. - Editor CSS is now added inline by WordPress.
Fixes an issue @dreamwhisper discovered where changing Customizer colors would not update button colors in the preview until changes are published.
…styles Generate inline styles for the block editor from theme support declarations
This is no longer required as of Genesis 2.9.0. It was previously used to set the footer credit URL. In Genesis 2.9.0 this is now pulled from the Theme URI header in the stylesheet. See studiopress/genesis#2166.
CHILD_THEME_NAME is no longer required as of Genesis 2.9.0. It was previously used to set the footer credit text and as the handle for the enqueued stylesheet. In Genesis 2.9.0 the name is now pulled from the Theme Name header for the site footer, and a sanitized version of the same value is used as the stylesheet handle. See studiopress/genesis#2166. The CHILD_THEME_HANDLE constant is used instead for enqueueing scripts and styles. Where a human-readable name is needed (admin notices), it is pulled directly from the stylesheet Theme Name line. The goal is to reduce the number of places where people need to set their theme name and version number. The sanitized Name is used for the CHILD_THEME_HANDLE instead of the Text Domain because we have often seen modified Genesis Sample themes where the name is changed but the text domain is not. We could switch to the Text Domain once this is implemented: #142. It's also likely that we'll switch away from constants and use helper functions should those become available in Genesis. This would offer better cache-busting during development, where assets can change often but version strings do not. studiopress/genesis#2199 (comment).
Command is still `npm run zip`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
genesis_get_config()function from Genesis 2.8.0. (Seefunctions.phpand theconfig/folder.) Requires Genesis 2.9.0+.theme-primaryandtheme-secondaryslugs for Block Editor color palette to prevent possible loss of styling when switching themes. We are now using this convention for new StudioPress theme releases and updates and encourage theme developers to do the same.lib/gutenberg/inline-styles.phpand Generate inline styles for the block editor from theme support declarations #198.config/block-editor-settings.php./wp-admin/admin.php?page=genesis-getting-startedinstead.